[ 
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597358
 ]

ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/May/21 09:22
            Start Date: 16/May/21 09:22
    Worklog Time Spent: 10m 
      Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841791184


   It looks like providing compatibility with Android OS may not be practical.
   Android has its own graphics and media classes.  So anything with java.awt
   in it will not port. Common Imaging using BufferedImage extensively.   Most
   other AWT elements are used only a little.  Color shows up the most.  The
   ICC_ColorSpace also shows up. A couple of the test applications use
   Graphics to draw some test images as input.
   
   I think I might post a question on Java Coderanch or Stackoverflow to ask
   about compatible solutions.
   
   
   On Sat, May 15, 2021 at 8:18 AM Bruno P. Kinoshita ***@***.***>
   wrote:
   
   > If those classes are from awt, the issue is that we have a dependency to
   > java.desktop (I think that's the java module name) and also cause an issue
   > to users of the API that are using Android (as IIUC, there's no awt in
   > Android's Java SDK?).
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
<https://github.com/apache/commons-imaging/pull/116#issuecomment-841649340>,
   > or unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AEWJDYNES4M3XQCOJIEZN6TTNZRAXANCNFSM4WPUJSLQ>
   > .
   >
   
   Search "java.awt" (229 hits in 121 files of 557 searched)
   commons-imaging\src\main\java\org\apache\commons\imaging\ColorTools.java (11 
hits)
        Line 20: import java.awt.RenderingHints;
        Line 21: import java.awt.Transparency;
        Line 22: import java.awt.color.ColorSpace;
        Line 23: import java.awt.color.ICC_ColorSpace;
        Line 24: import java.awt.color.ICC_Profile;
        Line 25: import java.awt.image.BufferedImage;
        Line 26: import java.awt.image.ColorConvertOp;
        Line 27: import java.awt.image.ColorModel;
        Line 28: import java.awt.image.ComponentColorModel;
        Line 29: import java.awt.image.DirectColorModel;
        Line 30: import java.awt.image.ImagingOpException;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\BufferedImageFactory.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\ImageBuilder.java
 (9 hits)
        Line 43: import java.awt.color.ColorSpace;
        Line 44: import java.awt.image.BufferedImage;
        Line 45: import java.awt.image.ColorModel;
        Line 46: import java.awt.image.DataBuffer;
        Line 47: import java.awt.image.DataBufferInt;
        Line 48: import java.awt.image.DirectColorModel;
        Line 49: import java.awt.image.Raster;
        Line 50: import java.awt.image.RasterFormatException;
        Line 51: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\RgbBufferedImageFactory.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\SimpleBufferedImageFactory.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpImageParser.java
 (2 hits)
        Line 27: import java.awt.Dimension;
        Line 28: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterPalette.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterRgb.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\dcx\DcxImageParser.java
 (2 hits)
        Line 23: import java.awt.Dimension;
        Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\gif\GifImageParser.java
 (2 hits)
        Line 28: import java.awt.Dimension;
        Line 29: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsDecoder.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsImageParser.java
 (2 hits)
        Line 23: import java.awt.Dimension;
        Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\ico\IcoImageParser.java
 (2 hits)
        Line 26: import java.awt.Dimension;
        Line 27: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\jpeg\decoder\JpegDecoder.java
 (6 hits)
        Line 21: import java.awt.image.BufferedImage;
        Line 22: import java.awt.image.ColorModel;
        Line 23: import java.awt.image.DataBuffer;
        Line 24: import java.awt.image.DirectColorModel;
        Line 25: import java.awt.image.Raster;
        Line 26: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\jpeg\JpegImageMetadata.java
 (2 hits)
        Line 19: import java.awt.Dimension;
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\jpeg\JpegImageParser.java
 (2 hits)
        Line 23: import java.awt.Dimension;
        Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pcx\PcxImageParser.java
 (11 hits)
        Line 24: import java.awt.Dimension;
        Line 25: import java.awt.Transparency;
        Line 26: import java.awt.color.ColorSpace;
        Line 27: import java.awt.image.BufferedImage;
        Line 28: import java.awt.image.ColorModel;
        Line 29: import java.awt.image.ComponentColorModel;
        Line 30: import java.awt.image.DataBuffer;
        Line 31: import java.awt.image.DataBufferByte;
        Line 32: import java.awt.image.IndexColorModel;
        Line 33: import java.awt.image.Raster;
        Line 34: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pcx\PcxWriter.java
 (1 hit)
        Line 18: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\png\PngImageParser.java
 (6 hits)
        Line 25: import java.awt.Dimension;
        Line 26: import java.awt.color.ColorSpace;
        Line 27: import java.awt.color.ICC_ColorSpace;
        Line 28: import java.awt.color.ICC_Profile;
        Line 29: import java.awt.image.BufferedImage;
        Line 30: import java.awt.image.ColorModel;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\png\PngWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\png\ScanExpediter.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\png\ScanExpediterInterlaced.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\png\ScanExpediterSimple.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PamWriter.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PbmWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PgmWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PnmImageParser.java
 (2 hits)
        Line 22: import java.awt.Dimension;
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PnmWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\pnm\PpmWriter.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\psd\dataparsers\DataParser.java
 (2 hits)
        Line 19: import java.awt.image.BufferedImage;
        Line 20: import java.awt.image.DataBuffer;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\psd\datareaders\CompressedDataReader.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\psd\datareaders\DataReader.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\psd\datareaders\UncompressedDataReader.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\psd\PsdImageParser.java
 (2 hits)
        Line 26: import java.awt.Dimension;
        Line 27: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\rgbe\RgbeImageParser.java
 (10 hits)
        Line 19: import java.awt.Dimension;
        Line 20: import java.awt.Point;
        Line 21: import java.awt.Transparency;
        Line 22: import java.awt.color.ColorSpace;
        Line 23: import java.awt.image.BandedSampleModel;
        Line 24: import java.awt.image.BufferedImage;
        Line 25: import java.awt.image.ComponentColorModel;
        Line 26: import java.awt.image.DataBuffer;
        Line 27: import java.awt.image.DataBufferFloat;
        Line 28: import java.awt.image.Raster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\datareaders\DataReaderStrips.java
 (1 hit)
        Line 20: import java.awt.Rectangle;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\datareaders\DataReaderTiled.java
 (1 hit)
        Line 26: import java.awt.Rectangle;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\datareaders\ImageDataReader.java
 (1 hit)
        Line 32: import java.awt.Rectangle;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PaletteEntry.java
 (1 hit)
        Line 19: import java.awt.Color;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PaletteEntryForRange.java
 (1 hit)
        Line 19: import java.awt.Color;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PaletteEntryForValue.java
 (1 hit)
        Line 19: import java.awt.Color;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PhotometricInterpreterFloat.java
 (1 hit)
        Line 19: import java.awt.Color;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\TiffDirectory.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\TiffImageMetadata.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\TiffImageParser.java
 (3 hits)
        Line 28: import java.awt.Dimension;
        Line 29: import java.awt.Rectangle;
        Line 30: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\tiff\write\TiffImageWriterBase.java
 (2 hits)
        Line 33: import java.awt.image.BufferedImage;
        Line 34: import java.awt.image.ColorModel;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\wbmp\WbmpImageParser.java
 (7 hits)
        Line 21: import java.awt.Dimension;
        Line 22: import java.awt.image.BufferedImage;
        Line 23: import java.awt.image.DataBuffer;
        Line 24: import java.awt.image.DataBufferByte;
        Line 25: import java.awt.image.IndexColorModel;
        Line 26: import java.awt.image.Raster;
        Line 27: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\xbm\XbmImageParser.java
 (8 hits)
        Line 19: import java.awt.Dimension;
        Line 20: import java.awt.image.BufferedImage;
        Line 21: import java.awt.image.ColorModel;
        Line 22: import java.awt.image.DataBuffer;
        Line 23: import java.awt.image.DataBufferByte;
        Line 24: import java.awt.image.IndexColorModel;
        Line 25: import java.awt.image.Raster;
        Line 26: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\xpm\XpmImageParser.java
 (8 hits)
        Line 18: import java.awt.Dimension;
        Line 19: import java.awt.image.BufferedImage;
        Line 20: import java.awt.image.ColorModel;
        Line 21: import java.awt.image.DataBuffer;
        Line 22: import java.awt.image.DirectColorModel;
        Line 23: import java.awt.image.IndexColorModel;
        Line 24: import java.awt.image.Raster;
        Line 25: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\icc\IccProfileParser.java
 (1 hit)
        Line 23: import java.awt.color.ICC_Profile;
   commons-imaging\src\main\java\org\apache\commons\imaging\ImageDump.java (4 
hits)
        Line 19: import java.awt.color.ColorSpace;
        Line 20: import java.awt.color.ICC_ColorSpace;
        Line 21: import java.awt.color.ICC_Profile;
        Line 22: import java.awt.image.BufferedImage;
   commons-imaging\src\main\java\org\apache\commons\imaging\ImageParser.java (2 
hits)
        Line 19: import java.awt.Dimension;
        Line 20: import java.awt.image.BufferedImage;
   commons-imaging\src\main\java\org\apache\commons\imaging\Imaging.java (3 
hits)
        Line 22: import java.awt.Dimension;
        Line 23: import java.awt.color.ICC_Profile;
        Line 24: import java.awt.image.BufferedImage;
   commons-imaging\src\main\java\org\apache\commons\imaging\internal\Debug.java 
(1 hit)
        Line 19: import java.awt.color.ICC_Profile;
   
commons-imaging\src\main\java\org\apache\commons\imaging\palette\Dithering.java 
(1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\palette\MedianCutQuantizer.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\palette\PaletteFactory.java
 (3 hits)
        Line 19: import java.awt.color.ColorSpace;
        Line 20: import java.awt.image.BufferedImage;
        Line 21: import java.awt.image.ColorModel;
   
commons-imaging\src\test\java\org\apache\commons\imaging\common\bytesource\ByteSourceImageTest.java
 (2 hits)
        Line 24: import java.awt.Dimension;
        Line 25: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\common\bytesource\ByteSourceInputStreamTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\common\ImageBuilderTest.java
 (3 hits)
        Line 19: import java.awt.image.BufferedImage;
        Line 20: import java.awt.image.ColorModel;
        Line 21: import java.awt.image.RasterFormatException;
   
commons-imaging\src\test\java\org\apache\commons\imaging\common\RgbBufferedImageFactoryTest.java
 (1 hit)
        Line 22: import java.awt.image.DirectColorModel;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\ApacheImagingSpeedAndMemoryTest.java
 (1 hit)
        Line 156: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\ImageReadExample.java
 (5 hits)
        Line 19: import java.awt.GraphicsConfiguration;
        Line 20: import java.awt.GraphicsDevice;
        Line 21: import java.awt.GraphicsEnvironment;
        Line 22: import java.awt.Transparency;
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\ImageWriteExample.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\SampleUsage.java
 (3 hits)
        Line 19: import java.awt.Dimension;
        Line 20: import java.awt.color.ICC_Profile;
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\tiff\ExampleReadFloatingPointData.java
 (2 hits)
        Line 19: import java.awt.Color;
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\tiff\ReadAndRenderFloatingPoint.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\examples\tiff\ReadTagsAndImages.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\bmp\BmpReadTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\bmp\BmpRoundtripTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\bmp\BmpWriterRgbTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\dcx\DcxReadTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\gif\GifReadTest.java
 (1 hit)
        Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\icns\IcnsReadTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\icns\IcnsRoundTripTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\ico\IcoReadTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\ico\IcoRoundtripTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\jpeg\exif\MicrosoftTagTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\jpeg\iptc\IptcFullDiscardTest.java
 (2 hits)
        Line 20: import java.awt.Graphics2D;
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\jpeg\JpegReadTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\jpeg\JpegWithJpegThumbnailTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\jpeg\specific\JpegImageParserTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\pam\PamReadTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\pcx\PcxReadTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\ConvertPngToGifTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\PngMultipleRoundtripTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\PngReadTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\PngTextTest.java
 (2 hits)
        Line 24: import java.awt.Color;
        Line 25: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\PngWriteForceTrueColorText.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\png\PngWriteReadTest.java
 (1 hit)
        Line 25: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\pnm\PnmImageParserTest.java
 (2 hits)
        Line 23: import java.awt.image.BufferedImage;
        Line 24: import java.awt.image.DataBufferInt;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\psd\PsdReadTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\rgbe\RgbeReadTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PaletteEntryForRangeTest.java
 (1 hit)
        Line 24: import java.awt.Color;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PaletteEntryForValueTest.java
 (1 hit)
        Line 24: import java.awt.Color;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\photometricinterpreters\floatingpoint\PhotometricInterpreterFloatTest.java
 (1 hit)
        Line 23: import java.awt.Color;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffAlphaRoundTripTest.java
 (4 hits)
        Line 19: import java.awt.AlphaComposite;
        Line 20: import java.awt.Color;
        Line 21: import java.awt.Graphics2D;
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffCcittTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffFloatingPointReadTest.java
 (2 hits)
        Line 23: import java.awt.Color;
        Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffFloatingPointRoundTripTest.java
 (1 hit)
        Line 23: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffReadAlphaTest.java
 (3 hits)
        Line 19: import java.awt.Color;
        Line 20: import java.awt.Graphics2D;
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffReadTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffRoundtripTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\tiff\TiffSubImageTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\wbmp\WbmpReadTest.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\xbm\XbmReadTest.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\xmp\XmpUpdateTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\formats\xpm\XpmReadTest.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   commons-imaging\src\test\java\org\apache\commons\imaging\ImageDumpTest.java 
(2 hits)
        Line 21: import java.awt.color.ColorSpace;
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\palette\DitheringTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\palette\PaletteQuantizationTest.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\BitmapRoundtripTest.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\FullColorRoundtrip.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\GrayscaleRountripTest.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\ImageAsserts.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\LimitedColorRoundtripTest.java
 (1 hit)
        Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\NullParametersRoundtripTest.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\PixelDensityRoundtrip.java
 (1 hit)
        Line 22: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\RoundtripBase.java
 (1 hit)
        Line 21: import java.awt.image.BufferedImage;
   
commons-imaging\src\test\java\org\apache\commons\imaging\roundtrip\TestImages.java
 (1 hit)
        Line 19: import java.awt.image.BufferedImage;
   Search "java.awt" (0 hits in 0 files of 1 searched)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 597358)
    Time Spent: 3.5h  (was: 3h 20m)

> There should be a Parameters class
> ----------------------------------
>
>                 Key: IMAGING-159
>                 URL: https://issues.apache.org/jira/browse/IMAGING-159
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.*
>    Affects Versions: 1.0-alpha2
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>              Labels: github
>             Fix For: 1.0-alpha3
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem 
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
>   if (!(value instanceof Number)) {
>     throw new ImageWriteException(
>       "Invalid compression parameter, must be numeric: "
>          + value);
>   }
>   compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides 
> additional methods like {{public int getInt(String key)}}. The implementation 
> could then look up the value from the map through an exception if it is null 
> or not a number.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to