[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597201
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/21 11:39
Start Date: 15/May/21 11:39
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841644514
AFAIK there are two candidates to do the getter: either the Java Rectangle
class or implement out own version of the Rectangle. At one point you
wanted to avoid java at classes, but in this case, I think Rectangle has
advantages
On Sat, May 15, 2021, 1:44 AM Bruno P. Kinoshita ***@***.***>
wrote:
> @gwlucastrig <https://github.com/gwlucastrig>
>
> great suggestion from @gwlucastrig <https://github.com/gwlucastrig> :
> "use one call for setSubImage, rather than 4 separate calls for
> setSubImageX, Y, Width, Height."
>
> I started making this change in the TiffImagingParameter. First the public
> void setSubImage(Integer width, Integer height, Integer x, Integer y).
> All good so far.
>
> But when I finished and started adding the getter, I was thinking in
> Python or JS, and wanted to return all the 4 parameters at once đŸ˜¥ Then I
> realized I would have to create another class to return the 4 parameters…
> do you have any suggestion for the getter of the subimage in the tiff
> imaging parameter class?
>
> Thanks!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/commons-imaging/pull/116#issuecomment-841605341>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AEWJDYOC6UHIHBYT2C46XRDTNYC5FANCNFSM4WPUJSLQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597201)
Time Spent: 2h 50m (was: 2h 40m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
