[
https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107013#comment-13107013
]
Daniel Pitts commented on OGNL-21:
----------------------------------
Going through the diff, I've plugged OgnlRuntime.*(methodName) into google code
search. While not exhaustive, it does give a sense for which methods are used.
I see one of use of getPropertyDescriptorsArray, which is a broken method and
either shouldn't be used, or should be fixed.
I see a couple use of the deprecated method "callMethod", which is very easily
replaced.
I did find legitimate uses for the methods I wanted to remove from SimpleNode.
So Mr. Tripodi, how do you want to handle this? I'll have to regenerate the
patch since there have been commits to OgnlRuntime since I created it. Does
this sound reasonable, given my research above?
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
> Key: OGNL-21
> URL: https://issues.apache.org/jira/browse/OGNL-21
> Project: OGNL
> Issue Type: Task
> Reporter: Daniel Pitts
> Labels: cleanup
> Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode
> and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if
> used (it put an array into a cache which was used to also store Maps).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
