[
https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115553#comment-13115553
]
Maurizio Cucchiara commented on OGNL-21:
----------------------------------------
{quote}
The callMethod(OgnleContext, Object, String, String, Object[]) method is
deprecated anyway. I'm fine leaving that one in if you feel the need to,
however I was considering since this is for a release with a new major version
number, it could be a good time to remove deprecated methods and the like.
{quote}
Sorry, I didn't see the deprecated annotation, and I definitely agree with you
about the major version matter. Furthermore I have nothing against the patch
you proposed.
I also think that we could purge every deprecated method and the unused private
ones.
For the public api, IMO we should try to make life as easy as possible to the
OGNL users. Maybe provide a migration guide would be enough.
WDYT?
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
> Key: OGNL-21
> URL: https://issues.apache.org/jira/browse/OGNL-21
> Project: OGNL
> Issue Type: Task
> Reporter: Daniel Pitts
> Labels: cleanup
> Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode
> and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if
> used (it put an array into a cache which was used to also store Maps).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
