[
https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114826#comment-13114826
]
Maurizio Cucchiara commented on OGNL-21:
----------------------------------------
Hi Daniel,
I have just got a quick look at your patch. Unfortunately I have to say that
some of the methods you got rid of are still in use on Struts (see the [latest
CompoundRootAccessor
version|http://svn.apache.org/viewvc/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java?revision=911280&view=markup]
at line 232).
IMO OgnlRuntime is a public api, and it is difficult to detect unused
statements.
We should take into consideration every method starting from protected
visibility.
My 2 cents.
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
> Key: OGNL-21
> URL: https://issues.apache.org/jira/browse/OGNL-21
> Project: OGNL
> Issue Type: Task
> Reporter: Daniel Pitts
> Labels: cleanup
> Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode
> and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if
> used (it put an array into a cache which was used to also store Maps).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
