[
https://issues.apache.org/jira/browse/MATH-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460298#comment-13460298
]
Yannick TANGUY commented on MATH-863:
-------------------------------------
Hi Gilles,
Thanks for the commit ; I tested it and have some comments :
- there's a mistake in "double dotProduct(Quaternion q)" method : it calls
itself, instead of "return dotProduct(this,q)", and was not covered in the
junit test
- I also noticed that you removed the following methods : isIdentityQuaternion
(ok for me) and product(double[] v) -> I think the second one was useful..
- Why does there's a static method "product(Quaternion, Quaternion)" and
another method "multiply(Quaternion)". I suggest to keep "product(Quaternion)",
in reference to Hamilton product and to keep multiply (or the former and more
explicit scalarMultiply) for the scalar multiplication.
Yannick
> new Quaternion class added in complex package
> ---------------------------------------------
>
> Key: MATH-863
> URL: https://issues.apache.org/jira/browse/MATH-863
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 3.1
> Reporter: Julien Anxionnat
> Attachments: quaternion.patch, quaternion_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch provides a new class for the mathematical object "Quaternion" in
> the complex package.
> This quaternion is considered as a mathematical object (the Hamilton's
> hypercomplex number).
> Note that it's not a rotation quaternion which has to be a quaternion of norm
> one. Although this feature could be used for a getter in the Rotation class.
> This patch provides also some improvements in Precision class : a "double
> comparison epsilon" and a method to compute relative comparison.
> (Please, note that's it's my first contribution, and I apologize in advance
> for my mistakes…)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
