[ 
https://issues.apache.org/jira/browse/MATH-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460321#comment-13460321
 ] 

Julien Anxionnat commented on MATH-863:
---------------------------------------

Thanks a lot for the commit.

I'll provide in few minutes a little .patch for the "multiply" name and the 
mistakes Yannick revealed (dotProduct, junit test).

About the removal of the {{product(double[] v)}} method (and the two static q.v 
and v.q), I'm ok : with {{Quaternion(double[] v)}}, the user could easily 
computes these products.

And I can try the FieldElement implementation.

Julien
                
> new Quaternion class added in complex package
> ---------------------------------------------
>
>                 Key: MATH-863
>                 URL: https://issues.apache.org/jira/browse/MATH-863
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.1
>            Reporter: Julien Anxionnat
>         Attachments: quaternion.patch, quaternion_v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch provides a new class for the mathematical object "Quaternion" in 
> the complex package.
> This quaternion is considered as a mathematical object (the Hamilton's 
> hypercomplex number).
> Note that it's not a rotation quaternion which has to be a quaternion of norm 
> one. Although this feature could be used for a getter in the Rotation class.
> This patch provides also some improvements in Precision class : a "double 
> comparison epsilon" and a method to compute relative comparison.
> (Please, note that's it's my first contribution, and I apologize in advance 
> for my mistakes…) 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to