[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463689#comment-13463689
]
Gilles commented on MATH-811:
-----------------------------
bq. as the enumeration itself does not select anything (it is not a selector)
It depends on how you see it.
It was precisely my point that either we represent "slope direction" (which can
have only two values) or we restrict usage as a selector and _indeed_, in my
view, the enum with more than two elements contains the notion of selection.
Note the name "getSlopeDirectionSelector" (and not something like
"selectAllowedSlopeDirections"): the "allowed slope directions" will be
selected _later_, i.e. in the code that uses the value returned by
"getSlopeDirectionSelector".
But I agree that it could be confusing, hence my preference to represent the
two "slope directions", and return a set with both values to mean that both are
allowed!
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
> Key: MATH-811
> URL: https://issues.apache.org/jira/browse/MATH-811
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Yannick TANGUY
> Attachments: JIRA-811_slope_selection.patch,
> JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection
> feature.
> This would improve event detection for the final user (the possibility to
> ignore some events, and less computation time) and also correct a bug found
> while using OREKIT (see https://www.orekit.org/forge/issues/104) in our
> applications.
> The modification consists in adding a method (getSlopeSelection() : int) in
> EventHandler, and modifying one conditionnal in the method evaluateStep
> (class EventState).
> We can provide modified code and unitary tests for this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
