[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464686#comment-13464686
]
Yannick TANGUY commented on MATH-811:
-------------------------------------
Here is a new version of the patch (JIRA-811_slope_selection_V2.patch).
I implemented an enum in EventHandler, modified the conditionnal tests in
EventState.evaluateStep, in order to avoid XOR operators. I also added some
comments.
In the EventState class, the g0positive field was only used once in
evaluateStep to know if an event has occured. I modified the test in order to
use ga sign (ga is g(ta), at the beginning of the step) because when a step is
larger that maxCheckInterval value, "g0positive" was not updated.
The test class (EventStateTest) contains two new unitary tests, that cover the
8 different combinations of the criteria.
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
> Key: MATH-811
> URL: https://issues.apache.org/jira/browse/MATH-811
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Yannick TANGUY
> Attachments: JIRA-811_slope_selection.patch,
> JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection
> feature.
> This would improve event detection for the final user (the possibility to
> ignore some events, and less computation time) and also correct a bug found
> while using OREKIT (see https://www.orekit.org/forge/issues/104) in our
> applications.
> The modification consists in adding a method (getSlopeSelection() : int) in
> EventHandler, and modifying one conditionnal in the method evaluateStep
> (class EventState).
> We can provide modified code and unitary tests for this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
