[ 
https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717480#comment-16717480
 ] 

Gilles commented on NUMBERS-80:
-------------------------------

Hi Matt and Steve.

Please have a look at commit d216fe76769afcd8d271ba39038251bb5b9a4659.

> Quaternion Updates for commons-geometry
> ---------------------------------------
>
>                 Key: NUMBERS-80
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-80
>             Project: Commons Numbers
>          Issue Type: Task
>            Reporter: Matt Juntunen
>            Priority: Blocker
>
> The {{Quaternion}} class should be updated in order to allow the 
> {{QuaternionRotation}} class from commons-geometry to extend it. The 
> following updates are required:
> - Remove {{final}} class modifier.
> - Make constructor protected.
> In addition, it would be good to switch the names of the components from 
> {{q0, q1, q2, q3}} to {{w, x, y, z}}. The former assumes that the convention 
> that the scalar component is always listed first, which is not the case in 
> some domains. The latter convention is not ambiguous.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to