[
https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719263#comment-16719263
]
Matt Juntunen commented on NUMBERS-80:
--------------------------------------
{quote}Sure. But we should make sure to adopt the same across modules of
"Numbers"; the reference being class {{Complex}} where we agreed to follow the
C++ standard.
{quote}
Ok. I didn't know that {{Complex}} was serving as a reference for naming. Those
names I mentioned from {{Vector}} are what was in commons-math from before, so
I assumed that they had been standardized in some way. Perhaps commons-geometry
should change to match commons-numbers here?
> Quaternion Updates for commons-geometry
> ---------------------------------------
>
> Key: NUMBERS-80
> URL: https://issues.apache.org/jira/browse/NUMBERS-80
> Project: Commons Numbers
> Issue Type: Task
> Reporter: Matt Juntunen
> Priority: Blocker
>
> The {{Quaternion}} class should be updated in order to allow the
> {{QuaternionRotation}} class from commons-geometry to extend it. The
> following updates are required:
> - Remove {{final}} class modifier.
> - Make constructor protected.
> In addition, it would be good to switch the names of the components from
> {{q0, q1, q2, q3}} to {{w, x, y, z}}. The former assumes that the convention
> that the scalar component is always listed first, which is not the case in
> some domains. The latter convention is not ambiguous.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
