[
https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719080#comment-16719080
]
Matt Juntunen commented on NUMBERS-80:
--------------------------------------
I like it! Here a few notes:
* Is the {{Default}} class needed? Could we just use {{Quaternion}} itself
there?
* I think we should be consistent with the method names between this and
commons-geometry. There are a few differences currently that we should discuss:
** {{norm}} vs {{getNorm}}
** {{normSq}} vs {{getNormSq}}
** {{minus}} vs {{negate}}
** {{inverse}} vs {{getInverse}} (from {{AffineTransformMatrix?D}} and
{{QuaternionRotation}})
** {{multiply(double}}) and {{divide(double) vs }}{{scalarMultiply}}
* The names {{a, b, c, d}} in the public methods parameters and documentation
should probably be changed to {{w, x, y, z}} for consistency.
> Quaternion Updates for commons-geometry
> ---------------------------------------
>
> Key: NUMBERS-80
> URL: https://issues.apache.org/jira/browse/NUMBERS-80
> Project: Commons Numbers
> Issue Type: Task
> Reporter: Matt Juntunen
> Priority: Blocker
>
> The {{Quaternion}} class should be updated in order to allow the
> {{QuaternionRotation}} class from commons-geometry to extend it. The
> following updates are required:
> - Remove {{final}} class modifier.
> - Make constructor protected.
> In addition, it would be good to switch the names of the components from
> {{q0, q1, q2, q3}} to {{w, x, y, z}}. The former assumes that the convention
> that the scalar component is always listed first, which is not the case in
> some domains. The latter convention is not ambiguous.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
