[
https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719185#comment-16719185
]
Gilles commented on NUMBERS-80:
-------------------------------
bq. Is the Default class needed?
I think so; class {{Quaternion}} is abstract.
bq. consistent \[...\] method names
Sure. But we should make sure to adopt the same across modules of "Numbers";
the reference being class {{Complex}} where we agreed to follow the C++
standard.
I prefer {{norm}} over {{getNorm}} because it is shorter _and_ it is does not
give the (sometimes false) impression that we merely return a stored value.
bq. negate
+1 (my mistake)
bq. scalarMultiply
Why?
Method overloading is a feature (cf. {{Complex}} class).
bq. names a, b, c, d
No problem if someone updates them in a PR specifically intended for
prettifying the code.
> Quaternion Updates for commons-geometry
> ---------------------------------------
>
> Key: NUMBERS-80
> URL: https://issues.apache.org/jira/browse/NUMBERS-80
> Project: Commons Numbers
> Issue Type: Task
> Reporter: Matt Juntunen
> Priority: Blocker
>
> The {{Quaternion}} class should be updated in order to allow the
> {{QuaternionRotation}} class from commons-geometry to extend it. The
> following updates are required:
> - Remove {{final}} class modifier.
> - Make constructor protected.
> In addition, it would be good to switch the names of the components from
> {{q0, q1, q2, q3}} to {{w, x, y, z}}. The former assumes that the convention
> that the scalar component is always listed first, which is not the case in
> some domains. The latter convention is not ambiguous.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
