[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990468#comment-16990468
]
Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------
Thanks; we are getting closer...
Nit-picks:
* Convention for opening braces (on the same line)
* Class and field names (should be be complete names – e.g. {{Iter}}, {{md}})
* Javadoc: avoid use of HTML entities.
API issue:
* Interface {{HashFunction}}: I don't think that [Collections] is going to
impose a convention on the naming of hash functions (or I'm missing something
about the purpose of the {{getName()}} method). Its use to ensure compatibility
between functions seems fragile; the comparison logic should rather be defined
by the standard {{equals(Object)}} method, or some other {{Comparator}}.
Implementation issues:
* Classes are not mutable (e.g. {{BloomFilter}}, {{BitSetBloomFilter}})
* Nested {{Iter}} class (in {{StaticHasher}}) wraps an {{Iterator<Integer>}}
and using the {{PrimitiveIterator.OfInt}} would probably loose a lot of
performance despite the impression of the contrary from a user's POV.
> BloomFilter contribution
> ------------------------
>
> Key: COLLECTIONS-728
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
> Project: Commons Collections
> Issue Type: Task
> Reporter: Claude Warren
> Priority: Minor
> Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java,
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated
> collections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
