[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990667#comment-16990667
]
Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------
bq. you know all the possible values. We don't, we can't, and we never will.
Isn't your code assuming that every implementation of some algorithm will name
it the same way (and that the name will comply with the Javadoc of
{{HashFunction}} defined here?
Conversely, one can imagine that two implementations could bear the same name,
even if one is broken and actually not compatible with the other.
bq. we would have to include enums for patently "broken" hashes
Yes, if this library purports to support them.
However given that in both cases (name or enum), we don't have control on the
source code (of the hash algorithm implementation), I wonder whether there
should really be a {{verifyHasher}} (i.e. it could simply be the application
developer's responsibility to ensure consistency of his use of the
{{BloomFilter}} functionality).
> BloomFilter contribution
> ------------------------
>
> Key: COLLECTIONS-728
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
> Project: Commons Collections
> Issue Type: Task
> Reporter: Claude Warren
> Priority: Minor
> Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java,
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated
> collections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
