Claudenw commented on a change in pull request #140: Bloomfilter updates2
URL: 
https://github.com/apache/commons-collections/pull/140#discussion_r391757352
 
 

 ##########
 File path: 
src/main/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilter.java
 ##########
 @@ -108,11 +118,15 @@ public boolean contains(final Hasher hasher) {
         });
 
         int limit = result.length;
 
 Review comment:
   if the max buffIdx was tracked you would know the where to trim.
   
   if (maxBuffIdx < result.length-1)
   {
       return Arrays.copyOf( result, maxBuffIdx+1 )
   }
   return result

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to