aherbert commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r391791829
########## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/Signatures.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.collections4.bloomfilter.hasher.function; + +import org.apache.commons.collections4.bloomfilter.hasher.HashFunction; +import org.apache.commons.collections4.bloomfilter.hasher.HashFunctionIdentity; + +/** + * Allow computation of HashFunction signatures. + * @since 4.5 + */ +final class Signatures { + Review comment: I don't think this necessary. It just clutters the public API with something trivial. The signature is defined in the javadoc for HashFunction. A developer can write this themselves. This is an internal function to ensure consistency. If public it should be promoted to the package above (hasher) where the HashFunction is defined. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
