aherbert commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r391794478
########## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionValidator.java ########## @@ -16,13 +16,43 @@ */ package org.apache.commons.collections4.bloomfilter.hasher; +import java.util.Locale; Review comment: I think we should focus on the core public API first. Helper classes can be exposed later when the core functionality is more fixed. This PR is addressing general tidy up before changes to the BloomFilter interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
