[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269863#comment-15269863
]
ASF GitHub Bot commented on CB-11198:
-------------------------------------
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975678
--- Diff: bin/lib/check_reqs.js ---
@@ -254,18 +252,22 @@ module.exports.check_android_target =
function(valid_target) {
}
var androidCmd = module.exports.getAbsoluteAndroidCmd();
- throw new CordovaError('Please install Android target: "' +
valid_target + '".\n\n' +
+ var msg = 'Please install Android target: "' + valid_target +
'".\n\n' +
'Hint: Open the SDK manager by running: ' + androidCmd + '\n' +
'You will require:\n' +
'1. "SDK Platform" for ' + valid_target + '\n' +
'2. "Android SDK Platform-tools (latest)\n' +
- '3. "Android SDK Build-tools" (latest)');
+ '3. "Android SDK Build-tools" (latest)'
--- End diff --
Missing semicolon.
> Skip checking android target installed
> --------------------------------------
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
