[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270301#comment-15270301
]
ASF GitHub Bot commented on CB-11198:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62002478
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
var args = this.getArgs(opts.buildType == 'debug' ? 'debug' :
'release', opts);
return check_reqs.check_ant()
.then(function() {
- return spawn('ant', args, {stdio: 'inherit'});
+ return spawn('ant', args, {stdio: 'pipe'});
+ }).progress(function (stdio){
--- End diff --
Should we handle stdio of `ant build` manually here?
> Skip checking android target installed
> --------------------------------------
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
