[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269864#comment-15269864
]
ASF GitHub Bot commented on CB-11198:
-------------------------------------
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975714
--- Diff: bin/lib/check_reqs.js ---
@@ -238,13 +236,13 @@ module.exports.getAbsoluteAndroidCmd = function () {
return cmd.replace(/(\s)/g, '\\$1');
};
-module.exports.check_android_target = function(valid_target) {
+module.exports.check_android_target = function(originalError) {
--- End diff --
I don't see where any value for originalError is ever passed in by a caller.
> Skip checking android target installed
> --------------------------------------
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
