[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269880#comment-15269880
]
ASF GitHub Bot commented on CB-11198:
-------------------------------------
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61976209
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -203,6 +203,11 @@ GradleBuilder.prototype.build = function(opts) {
} else {
process.stdout.write(stdio.stdout);
}
+ }).catch(function (error) {
+ if (error.toString().indexOf('failed to find target with hash
string') >= 0) {
+ return check_reqs.check_android_target(error);
--- End diff --
Would it be possible for check_android_target to actually find the target
and then swallow this error?
> Skip checking android target installed
> --------------------------------------
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
