[
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876947#comment-15876947
]
ASF GitHub Bot commented on CB-11346:
-------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/519
re:
https://issues.apache.org/jira/browse/CB-11346?focusedCommentId=15875577&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875577
Looks like there is more to it than the patch. The error occurs here:
https://github.com/apache/cordova-lib/blob/a9605411ab007d700849c971043f0c211c06100c/cordova-lib/src/cordova/platform.js#L389
All three conditions have to be satisfied:
1. version (from package.json)
2. platform name (from package.json name, has to be in the form of
cordova-XXXX where XXX is the actual platform name)
3. platform name exists in platformConfig.json file
We would have to remove checks 2 and 3, but not sure of the impact since
platformConfig.json contains information that is probably needed elsewhere
(ideally it would exist in the platform itself!)
> Remove known platforms check for Platform API
> ---------------------------------------------
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
