[
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877089#comment-15877089
]
ASF GitHub Bot commented on CB-11346:
-------------------------------------
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
I've started a discuss thread on this subject.
https://github.com/cordova/cordova-discuss/issues/64
@purplecabbage
risingj.com
On Tue, Feb 21, 2017 at 4:20 PM, Jesse <[email protected]> wrote:
> We should ultimately just be checking that there is a valid platformAPI,
> and if so, use it, otherwise fail.
> ( super simplification )
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Feb 21, 2017 at 4:19 PM, Jesse <[email protected]> wrote:
>
>> Yeah, it's deep. If a platform does not have a known name, there will be
>> issues currently.
>> The only way right now is to fork a blessed platform, but there is no way
>> to easily create your own with a generic name.
>>
>>
>>
>> @purplecabbage
>> risingj.com
>>
>> On Tue, Feb 21, 2017 at 4:16 PM, Shazron Abdullah <
>> [email protected]> wrote:
>>
>>> The src/platforms/platforms.js file touches almost all commands,
>>> particularly the use of the getPlatformAPI call, so removing this is
>>> tricky -- but at least there is only one API call to abstract away.
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/cordova-lib/pull/519#issuecomment-281525835>,
>>> or mute the thread
>>>
<https://github.com/notifications/unsubscribe-auth/AAC0NikI4Tm7AIyhXZB6Ke6Mt6i0-tDFks5re35ngaJpZM4MGyTP>
>>> .
>>>
>>
>>
>
> Remove known platforms check for Platform API
> ---------------------------------------------
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
