[
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887594#comment-15887594
]
ASF GitHub Bot commented on CB-11346:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/523
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=h1)
Report
> Merging
[#523](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr&el=desc)
will **decrease** coverage by `-0.01%`.
> The diff coverage is `95.45%`.
```diff
@@ Coverage Diff @@
## master #523 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.01%
=========================================
Files 68 68
Lines 5504 5503 -1
Branches 1090 1088 -2
=========================================
- Hits 4508 4507 -1
Misses 996 996
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
| `93.75% <ø> (-0.05%)` | :x: |
|
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
| `97.28% <100%> (ø)` | :white_check_mark: |
|
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
| `78.25% <100%> (ø)` | :white_check_mark: |
|
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
| `96.66% <92.85%> (+0.11%)` | :white_check_mark: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=footer).
Last update
[b0402b9...21c4565](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...21c4565b0760d4103ad707832fd15ab8b837ab1e?src=pr&el=footer&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Remove known platforms check for Platform API
> ---------------------------------------------
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
