[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356063#comment-16356063
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
janpio commented on issue #246: CB-13829 Fix tests that were broken since
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363906445
> It looks like the following test cases were added: 2b, 2c, 2d, 2e, 3b, 3c,
3d, 4b, 5b, 6b
> It appears that the test coverage would be expanded to cover Windows 8.1,
Windows Phone 8.1, Windows 10 and all possible CPU targets more completely.
Before the default was Win8.1, now it is Win10. That meant that the Win8.1
stuff that was automatically done before now has to be done explicitly. Also
some of the architecture splits that were possible with default Win8.1 are not
possible with Win10, so this had to be transformed as well.
But you are right, it is possible that one of these combinations was not
tested before. I have to be honest, I don't know well enough what actually was
tested and so could also not split this into its own PR 🤣
> I am still hoping we can have a release within the next few days to solve
the Windows 8.1 crash problem.
I can not do a release with failing tests which represent an actual problem,
which CB-13834 seems to do. Either the test is broken or the actual
implementation for VS2017 is broken - both won't allow me to cut a release.
The only way to do a 5.1 with the patch you need would be to go back to
before the UWP (and probably also test) changes, then cherry pick the one you
need and do a release only for with that. But that is definitely not a viable
option though because of the work involved, sorry. So we nee to get CB-13834
fixed, then I can continue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
