[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356008#comment-16356008
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
janpio commented on issue #246: CB-13829 Fix tests that were broken since
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363897813
> I would favor making these changes in two parts (maybe split into 2
different issues): one to fix the actual Windows build (with just enough test
coverage to prove it working) and another to fix and extend the test coverage.
In my opinion these changes actually are only to fix the previously existing
tests, I just went through those that didn't work and replace them with the new
equivalents for the new "UWP = standard" situation. I didn't really extend the
test coverage, did I? If so, it was more an accident ;)
> I do not really like the idea of moving the failing test function if we
expect to to move it right back. I would favor just marking it as pending (use
xit or pending function) and then fixing it in
issues.apache.org/jira/browse/CB-13834.
Yeah, in principle I agree - but I wanted to make sure the tests keep
failing as that test is actually broken. So moving it down just enabled them
all to run but it is still clearly visible that `master` is in a broken state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
