[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356005#comment-16356005
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
brodybits commented on issue #246: CB-13829 Fix tests that were broken since
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363897159
Thanks @janpio for the nice work so far. I gave my review comments what I
think are all minor (non-blocking), leaving it up to your best judgment. I am
also looking forward to the fix for
<https://issues.apache.org/jira/browse/CB-13834>. I am really hoping to see a
release to fix the crash on Windows 8.1
(https://issues.apache.org/jira/browse/CB-13175 - fixed in PR #239).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
