[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356015#comment-16356015
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
janpio commented on issue #246: CB-13829 Fix tests that were broken since
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363898512
Thanks for the review @brodybits, very helpful.
I did some smaller updates, and think I will "ignore" the other things for
now.
Do you think the "new"/rewritten tests are doing their job equivalent to
what was there before? If you agree, I think I will just merge this in to see
some progress here.
If you have any ideas about
https://issues.apache.org/jira/browse/CB-13834... I am pretty much out of ideas
as I can't reproduce locally and don't know what is going on on AppVeyor :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
