[
https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573642#comment-16573642
]
ASF GitHub Bot commented on CB-14263:
-------------------------------------
leo6104 edited a comment on issue #35: CB-14263: (android) make cordova plugin
compatible with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35#issuecomment-411502619
@janpio @raphinesse Thank you for quick comment :) I agree with the point
that if there is any platform-specific code should be implemented to
cordova-android not cordova-common, i can do that and i will. But i didn't know
what cordova-common plan before upload this issue because ConfigParser already
have platform-specific code. :)
I see the issue and i found that in pluginHandlers, there is no
`config-file` handler. So i think these compatibility issue still exists on
`config-file` tag use cases.
https://github.com/jcesarmobile/cordova-android/blob/master/bin/templates/cordova/lib/pluginHandlers.js
[Existing Problem]
When `plugin.xml` have `<config-file target="AndroidManifest.xml"
parent="/*">`, it silently skipped. but when i run android emulator, only alert
'Error cordova initializing ~~'.
Is there any code to alias config-file tag cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Makes all of cordova plugins compatible with cordova-android 7
> --------------------------------------------------------------
>
> Key: CB-14263
> URL: https://issues.apache.org/jira/browse/CB-14263
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins, cordova-android, cordova-common
> Affects Versions: [email protected]
> Reporter: Heo
> Priority: Major
> Fix For: Master
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml,
> AndroidManifest.xml paths.
> [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192]
> But In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7
> syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing
> some plugins which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>
>
> I spent lots of times to fix this. I test it via my cutsom cordova-cli
> repository [https://github.com/leo6104/cordova-cli/] and i fix it in my
> cordova project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
