[ 
https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574561#comment-16574561
 ] 

ASF GitHub Bot commented on CB-14263:
-------------------------------------

leo6104 commented on issue #35:  CB-14263: (android) make cordova plugin 
compatible with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35#issuecomment-411698077
 
 
   I found strange behavior. 
   
   For test, i remove all platforms & plugins folder in my project and run 
`cordova platform add [email protected]` and watch 
`platforms/android/app/src/main/res/xml/config.xml` file while processing 
platform add.
   
   In platforms/android/app/src/main/res/xml/config.xml, while Discovering 
plugins & adding progress, it seems merge well. but after the command `cordova 
platform add` finish, `platforms/android/app/src/main/res/xml/config.xml` only 
have some plugins which correctly define config.xml path in their plugin.xml.
   
   ```
   com.telerik.plugins.nativepagetransitions
   com-sarriaroman-photoviewer
   cordova-plugin-android-permissions
   cordova-plugin-customurlscheme
   cordova-plugin-device
   cordova-plugin-dialogs
   cordova-plugin-enable-multidex
   cordova-plugin-facebook4
   cordova-plugin-file
   cordova-plugin-file-opener2
   cordova-plugin-igaworks
   cordova-plugin-inapppurchase
   cordova-plugin-ionic-webview
   cordova-plugin-keyboard
   cordova-plugin-nativestorage
   cordova-plugin-naver
   cordova-plugin-splashscreen
   cordova-plugin-statusbar
   cordova-plugin-whitelist
   cordova-plugin-x-socialsharing
   cordova-plugin-x-toast
   cordova-support-google-services
   es6-promise-plugin
   phonegap-plugin-multidex
   ``` 
   Here is my plugin list.  all of plugin version is latest

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Makes all of cordova plugins compatible with cordova-android 7
> --------------------------------------------------------------
>
>                 Key: CB-14263
>                 URL: https://issues.apache.org/jira/browse/CB-14263
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: AllPlugins, cordova-android, cordova-common
>    Affects Versions: [email protected]
>            Reporter: Heo
>            Priority: Major
>             Fix For: Master
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml, 
> AndroidManifest.xml paths. 
> [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192]
>  But In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7 
> syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing 
> some plugins which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>  
>  
> I spent lots of times to fix this. I test it via my cutsom cordova-cli 
> repository [https://github.com/leo6104/cordova-cli/] and i fix it in my 
> cordova project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to