[
https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573924#comment-16573924
]
ASF GitHub Bot commented on CB-14263:
-------------------------------------
jcesarmobile edited a comment on issue #35: CB-14263: (android) make cordova
plugin compatible with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35#issuecomment-411560359
I agree, I think we shouldn’t add platform specific code here. Also this
will break old platforms on new cli, not sure what’s our support policy for
older platforms on newer clips though.
Also, I think this kind of problems should be fixed already in
Cordova-android. Can you add cordova-Android from master or 7.1.x branch and
see if the problem persists? And in case it persists, can you try to fix it
there if possible?
BTW, this is the PR that should have fixed the problem, as the real problem
was cordova-Android not detecting properly the type of project, so it looked
for the AndroidManifest.xml and some other files in the wrong location
https://github.com/apache/cordova-android/pull/437/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Makes all of cordova plugins compatible with cordova-android 7
> --------------------------------------------------------------
>
> Key: CB-14263
> URL: https://issues.apache.org/jira/browse/CB-14263
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins, cordova-android, cordova-common
> Affects Versions: [email protected]
> Reporter: Heo
> Priority: Major
> Fix For: Master
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml,
> AndroidManifest.xml paths.
> [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192]
> But In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7
> syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing
> some plugins which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>
>
> I spent lots of times to fix this. I test it via my cutsom cordova-cli
> repository [https://github.com/leo6104/cordova-cli/] and i fix it in my
> cordova project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
