[
https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574183#comment-16574183
]
ASF GitHub Bot commented on CB-14263:
-------------------------------------
leo6104 commented on issue #35: CB-14263: (android) make cordova plugin
compatible with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35#issuecomment-411612375
@jcesarmobile cordova-android master or 7.1.x branch dosn't work well.
I tried to fix it but i face some point it could be breaking changes.
https://github.com/apache/cordova-android/blob/59018ab632e99b3e45a0bf9657c70282aeeac7bf/bin/templates/cordova/lib/prepare.js#L40
In `prepare` process in cordova android, there is no code to control
`target` path in config-file tag for plugins. cordova-android just call
cordova-common's PluginMunger to process plugin installation.
ConfigChanges in cordova-common only do some plugin apply process.
https://github.com/apache/cordova-common/blob/master/src/ConfigChanges/ConfigChanges.js#L419
My thought about this issue (with minimum code changes in cordova-android)
1. Extend PluginInfoProvider in cordova-android
2. Implement get method and check the target exists or not. if not exists,
append prefix path 'app/src/main' to the target path.
3. It will make
https://github.com/apache/cordova-common/blob/master/src/ConfigChanges/ConfigChanges.js#L413
this get method line work.
Is it okay? or any ideas to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Makes all of cordova plugins compatible with cordova-android 7
> --------------------------------------------------------------
>
> Key: CB-14263
> URL: https://issues.apache.org/jira/browse/CB-14263
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins, cordova-android, cordova-common
> Affects Versions: [email protected]
> Reporter: Heo
> Priority: Major
> Fix For: Master
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml,
> AndroidManifest.xml paths.
> [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192]
> But In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7
> syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing
> some plugins which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>
>
> I spent lots of times to fix this. I test it via my cutsom cordova-cli
> repository [https://github.com/leo6104/cordova-cli/] and i fix it in my
> cordova project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
