ASF GitHub Bot commented on DRILL-4373:

Github user parthchandra commented on a diff in the pull request:

    --- Diff: 
    @@ -754,15 +764,45 @@ public void testImpalaParquetVarBinary_DictChange() 
throws Exception {
    +  @Test
    +  public void testImpalaParquetBinaryTimeStamp_DictChange() throws 
Exception {
    +    try {
    +      test("alter session set %s = true", 
    +      compareParquetReadersColumnar("field_impala_ts", 
    --- End diff --
    This is not a good enough test. Both the baseline and test case queries 
will use the getDateTimeValueFromBinary method and if there is a bug in that 
method, the test will still pass as both will produce the same incorrect value. 
Better to compare with the actual baseline value in the file.

> Drill and Hive have incompatible timestamp representations in parquet
> ---------------------------------------------------------------------
>                 Key: DRILL-4373
>                 URL: https://issues.apache.org/jira/browse/DRILL-4373
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Hive, Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Rahul Challapalli
>            Assignee: Karthikeyan Manivannan
>              Labels: doc-impacting
>             Fix For: 1.9.0
> git.commit.id.abbrev=83d460c
> I created a parquet file with a timestamp type using Drill. Now if I define a 
> hive table on top of the parquet file and use "timestamp" as the column type, 
> drill fails to read the hive table through the hive storage plugin

This message was sent by Atlassian JIRA

Reply via email to