[ 
https://issues.apache.org/jira/browse/DRILL-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583934#comment-15583934
 ] 

ASF GitHub Bot commented on DRILL-4373:
---------------------------------------

Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/600#discussion_r83761501
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
 ---
    @@ -45,4 +53,34 @@ public static int getIntFromLEBytes(byte[] input, int 
start) {
         }
         return out;
       }
    +
    +  /**
    +   * Utilities for converting from parquet INT96 binary (impala, hive 
timestamp)
    +   * to date time value. This utilizes the Joda library.
    +   */
    +  public static class NanoTimeUtils {
    +
    +    public static final long NANOS_PER_DAY = TimeUnit.DAYS.toNanos(1);
    +    public static final long NANOS_PER_HOUR = TimeUnit.HOURS.toNanos(1);
    +    public static final long NANOS_PER_MINUTE = 
TimeUnit.MINUTES.toNanos(1);
    +    public static final long NANOS_PER_SECOND = 
TimeUnit.SECONDS.toNanos(1);
    +    public static final long NANOS_PER_MILLISECOND =  
TimeUnit.MILLISECONDS.toNanos(1);
    +
    +  /**
    +   * @param binaryTimeStampValue
    +   *          hive, impala timestamp values with nanoseconds precision
    +   *          are stored in parquet Binary as INT96
    +   *
    +   * @return  the number of milliseconds since January 1, 1970, 00:00:00 
GMT
    +   *          represented by @param binaryTimeStampValue .
    +   */
    +    public static long getDateTimeValueFromBinary(Binary 
binaryTimeStampValue) {
    +      NanoTime nt = NanoTime.fromBinary(binaryTimeStampValue);
    +      int julianDay = nt.getJulianDay();
    +      long nanosOfDay = nt.getTimeOfDayNanos();
    +      return DateTimeUtils.fromJulianDay(julianDay-0.5d) + 
nanosOfDay/NANOS_PER_MILLISECOND;
    --- End diff --
    
    Sorry for the late reply. For some reason, I did not see these comments 
till now. 
    About 1) Yes, you are correct. I just want the comments in 
ConvertFromImpalaTimestamp to be removed.


> Drill and Hive have incompatible timestamp representations in parquet
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4373
>                 URL: https://issues.apache.org/jira/browse/DRILL-4373
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Hive, Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Rahul Challapalli
>            Assignee: Karthikeyan Manivannan
>              Labels: doc-impacting
>             Fix For: 1.9.0
>
>
> git.commit.id.abbrev=83d460c
> I created a parquet file with a timestamp type using Drill. Now if I define a 
> hive table on top of the parquet file and use "timestamp" as the column type, 
> drill fails to read the hive table through the hive storage plugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to