ASF GitHub Bot commented on DRILL-4373:

Github user vdiravka commented on a diff in the pull request:

    --- Diff: 
    @@ -754,15 +764,45 @@ public void testImpalaParquetVarBinary_DictChange() 
throws Exception {
    +  @Test
    +  public void testImpalaParquetBinaryTimeStamp_DictChange() throws 
Exception {
    +    try {
    +      test("alter session set %s = true", 
    +      compareParquetReadersColumnar("field_impala_ts", 
    --- End diff --
    1. Is it better to compare result with baseline columns and values from the 
file or it is ok to compare with `sqlBaselineQuery` and disabled new 
    2. In the process of investigating this test I found that the primitive 
data type of the column in the file `int96_dict_change.parquet`  is BINARY, not 
    I am a little bit confused with this. Do we need convert this BINARY to 
TIMESTAMP as well?
    CONVERT_FROM function with IMPALA_TIMESTAMP argument works properly for 
this field.
    I will investigate a little more about does impala and hive can store 
timestamps into parquet BINARY. 

> Drill and Hive have incompatible timestamp representations in parquet
> ---------------------------------------------------------------------
>                 Key: DRILL-4373
>                 URL: https://issues.apache.org/jira/browse/DRILL-4373
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Hive, Storage - Parquet
>    Affects Versions: 1.8.0
>            Reporter: Rahul Challapalli
>            Assignee: Karthikeyan Manivannan
>              Labels: doc-impacting
>             Fix For: 1.9.0
> git.commit.id.abbrev=83d460c
> I created a parquet file with a timestamp type using Drill. Now if I define a 
> hive table on top of the parquet file and use "timestamp" as the column type, 
> drill fails to read the hive table through the hive storage plugin

This message was sent by Atlassian JIRA

Reply via email to