[
https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002684#comment-16002684
]
ASF GitHub Bot commented on DRILL-5481:
---------------------------------------
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115475365
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
---
@@ -93,6 +107,14 @@ public void put(final String key, final V value, final
DataChangeVersion dataCha
throw new VersionMismatchException("Version mismatch detected",
dataChangeVersion.getVersion());
}
store.put(key, value);
+ currentSize.incrementAndGet();
+
+ if (currentSize.get() > maxCapacity) {
+ //Pop Out Oldest
+ ((ConcurrentSkipListMap<String, V>) store).pollLastEntry();
--- End diff --
should this be pollFirstEntry() ?
> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
> Key: DRILL-5481
> URL: https://issues.apache.org/jira/browse/DRILL-5481
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the
> life of the Drillbit), an existing test class
> {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored
> to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and
> given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit
> process' lifespan.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
