[
https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002975#comment-16002975
]
ASF GitHub Bot commented on DRILL-5481:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115534585
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -57,14 +59,14 @@ public LocalPersistentStoreProvider(final DrillConfig
config) throws StoreExcept
}
@Override
- public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) {
+ public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) throws StoreException {
switch(storeConfig.getMode()){
case BLOB_PERSISTENT:
case PERSISTENT:
- if (enableWrite) {
+ if (!useEphemeral) {
--- End diff --
This is changing the default behavior, as enableWrite/useEphemeral is true
by default.
> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
> Key: DRILL-5481
> URL: https://issues.apache.org/jira/browse/DRILL-5481
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the
> life of the Drillbit), an existing test class
> {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored
> to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and
> given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit
> process' lifespan.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
