[ 
https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002683#comment-16002683
 ] 

ASF GitHub Bot commented on DRILL-5481:
---------------------------------------

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r115486727
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -105,8 +105,10 @@
       String HTTP_TRUSTSTORE_PATH = "javax.net.ssl.trustStore";
       String HTTP_TRUSTSTORE_PASSWORD = "javax.net.ssl.trustStorePassword";
       String SYS_STORE_PROVIDER_CLASS = "drill.exec.sys.store.provider.class";
    +  String SYS_STORE_PROVIDER_ZK_BLOBROOT = 
"drill.exec.sys.store.provider.zk.blobroot";
       String SYS_STORE_PROVIDER_LOCAL_PATH = 
"drill.exec.sys.store.provider.local.path";
    -  String SYS_STORE_PROVIDER_LOCAL_ENABLE_WRITE = 
"drill.exec.sys.store.provider.local.write";
    +  String SYS_STORE_PROVIDER_EPHEMERAL_WRITE = 
"drill.exec.sys.store.provider.ephemeral.write";
    +  String SYS_STORE_PROVIDER_EPHEMERAL_CAPACITY = 
"drill.exec.sys.store.provider.ephemeral.capacity";
    --- End diff --
    
    How about ephemeral.maxProfiles instead of capacity ?


> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the 
> life of the Drillbit), an existing test class 
> {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored 
> to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and 
> given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit 
> process' lifespan.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to