[
https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002685#comment-16002685
]
ASF GitHub Bot commented on DRILL-5481:
---------------------------------------
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115485196
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -27,28 +27,30 @@
import org.apache.drill.exec.store.sys.PersistentStoreConfig;
import org.apache.drill.exec.store.sys.PersistentStoreRegistry;
import org.apache.drill.exec.store.sys.store.LocalPersistentStore;
-import org.apache.drill.exec.testing.store.NoWriteLocalStore;
+import org.apache.drill.exec.store.sys.store.EphemeralPersistentStore;
import org.apache.hadoop.fs.Path;
/**
* A really simple provider that stores data in the local file system, one
value per file.
*/
public class LocalPersistentStoreProvider extends
BasePersistentStoreProvider {
-// private static final Logger logger =
LoggerFactory.getLogger(LocalPersistentStoreProvider.class);
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(LocalPersistentStoreProvider.class);
private final Path path;
private final DrillFileSystem fs;
// This flag is used in testing. Ideally, tests should use a specific
PersistentStoreProvider that knows
// how to handle this flag.
- private final boolean enableWrite;
+ private final boolean useEphemeral;
+ private int maxCapacity;
--- End diff --
can we name this maxEphemeralCapacity or maxEphemeralProfiles ?
> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
> Key: DRILL-5481
> URL: https://issues.apache.org/jira/browse/DRILL-5481
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the
> life of the Drillbit), an existing test class
> {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored
> to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and
> given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit
> process' lifespan.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
