[ 
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151142#comment-16151142
 ] 

ASF GitHub Bot commented on DRILL-5723:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r136662040
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/work/metadata/TestMetadataProvider.java
 ---
    @@ -211,12 +217,15 @@ public void tablesWithTableNameFilter() throws 
Exception {
     
         assertEquals(RequestStatus.OK, resp.getStatus());
         List<TableMetadata> tables = resp.getTablesList();
    -    assertEquals(5, tables.size());
    +    assertEquals(7, tables.size());
     
         verifyTable("sys", "boot", tables);
         verifyTable("sys", "memory", tables);
         verifyTable("sys", "options", tables);
    +    verifyTable("sys", "options2", tables);
         verifyTable("sys", "version", tables);
    +    verifyTable("sys", "internal_options", tables);
    +    verifyTable("sys", "internal_options2", tables);
    --- End diff --
    
    Better name? Nobody is going to know what "options2" means... I certainly 
can't guess...


> Support System/Session Internal Options
> ---------------------------------------
>
>                 Key: DRILL-5723
>                 URL: https://issues.apache.org/jira/browse/DRILL-5723
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would 
> like to add internal options which can be altered, but are not visible in the 
> sys.options table. These internal options could be seen by another alias 
> select * from internal.options. The intention would be to put new options we 
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they 
> could be changed to appear in the sys.option table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to