[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151143#comment-16151143
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r136659109
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -421,13 +422,13 @@
* such as changing system options.
*/
String ADMIN_USERS_KEY = "security.admin.users";
- StringValidator ADMIN_USERS_VALIDATOR = new
StringValidator(ADMIN_USERS_KEY, true);
+ StringValidator ADMIN_USERS_VALIDATOR = new
StringValidator(ADMIN_USERS_KEY, new OptionValue.MetaData(true, false));
--- End diff --
We are adding a distinction between runtime options that the user can set
vs. those that the user cannot set? This is a very bizarre distinction as
runtime options are only for the user...
Actually, these are options that are "public" vs. those that exist, but are
generally "hidden", right?
Another very useful addition, while we're in the code, is between the
allowed "scope" of a setting. Today, all options can be set at the system and
session (per user) level. But some options, such as the memory per query, or
enabling queues, really only make sense at the system level. So, part of the
new metadata should be to specify "session-only" options and forbid setting
such options at the session level.
> Support System/Session Internal Options
> ---------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
