[
https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421538#comment-16421538
]
ASF GitHub Bot commented on DRILL-6284:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1181#discussion_r178445267
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -573,4 +610,21 @@ private LogicalExpression
materializeExpression(LogicalExpression expression, It
}
return materializedExpr;
}
+
+ private void updateStats() {
+ stats.setLongStat(MergeJoinBatch.Metric.LEFT_INPUT_BATCH_COUNT,
mergeJoinMemoryManager.getNumIncomingBatches(LEFT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.LEFT_AVG_INPUT_BATCH_BYTES,
mergeJoinMemoryManager.getAvgInputBatchSize(LEFT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.LEFT_AVG_INPUT_ROW_BYTES,
mergeJoinMemoryManager.getAvgInputRowWidth(LEFT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.LEFT_TOTAL_INPUT_RECORDS,
mergeJoinMemoryManager.getTotalInputRecords(LEFT_INDEX));
+
+ stats.setLongStat(MergeJoinBatch.Metric.RIGHT_INPUT_BATCH_COUNT,
mergeJoinMemoryManager.getNumIncomingBatches(RIGHT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.RIGHT_AVG_INPUT_BATCH_BYTES,
mergeJoinMemoryManager.getAvgInputBatchSize(RIGHT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.RIGHT_AVG_INPUT_ROW_BYTES,
mergeJoinMemoryManager.getAvgInputRowWidth(RIGHT_INDEX));
+ stats.setLongStat(MergeJoinBatch.Metric.RIGHT_TOTAL_INPUT_RECORDS,
mergeJoinMemoryManager.getTotalInputRecords(RIGHT_INDEX));
+
+ stats.setLongStat(MergeJoinBatch.Metric.OUTPUT_BATCH_COUNT,
mergeJoinMemoryManager.getNumOutgoingBatches());
+ stats.setLongStat(MergeJoinBatch.Metric.AVG_OUTPUT_BATCH_BYTES,
mergeJoinMemoryManager.getAvgOutputBatchSize());
+ stats.setLongStat(MergeJoinBatch.Metric.AVG_OUTPUT_ROW_BYTES,
mergeJoinMemoryManager.getAvgOutputRowWidth());
+ stats.setLongStat(MergeJoinBatch.Metric.TOTAL_OUTPUT_RECORDS,
mergeJoinMemoryManager.getTotalOutputRecords());
--- End diff --
As above, maybe also write the information to the log for easier debugging.
> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
> Key: DRILL-6284
> URL: https://issues.apache.org/jira/browse/DRILL-6284
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Critical
> Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
