[
https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421535#comment-16421535
]
ASF GitHub Bot commented on DRILL-6284:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1181#discussion_r178445224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -463,4 +489,21 @@ protected boolean setupNewSchema() throws
SchemaChangeException {
}
return exprs;
}
+
+ private void updateStats() {
+ stats.setLongStat(Metric.INPUT_BATCH_COUNT,
flattenMemoryManager.getNumIncomingBatches());
+ stats.setLongStat(Metric.AVG_INPUT_BATCH_BYTES,
flattenMemoryManager.getAvgInputBatchSize());
+ stats.setLongStat(Metric.AVG_INPUT_ROW_BYTES,
flattenMemoryManager.getAvgInputRowWidth());
+ stats.setLongStat(Metric.TOTAL_INPUT_RECORDS,
flattenMemoryManager.getTotalInputRecords());
+ stats.setLongStat(Metric.OUTPUT_BATCH_COUNT,
flattenMemoryManager.getNumOutgoingBatches());
+ stats.setLongStat(Metric.AVG_OUTPUT_BATCH_BYTES,
flattenMemoryManager.getAvgOutputBatchSize());
+ stats.setLongStat(Metric.AVG_OUTPUT_ROW_BYTES,
flattenMemoryManager.getAvgOutputRowWidth());
+ stats.setLongStat(Metric.TOTAL_OUTPUT_RECORDS,
flattenMemoryManager.getTotalOutputRecords());
--- End diff --
Not critical, but I found it super helpful to dump this information into
the log as well as as metrics. That way, when some issue arises, all the
information is in the logs, I didn't need to track down both the logs and the
query profile.
> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
> Key: DRILL-6284
> URL: https://issues.apache.org/jira/browse/DRILL-6284
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Critical
> Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
