[
https://issues.apache.org/jira/browse/DRILL-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491925#comment-16491925
]
ASF GitHub Bot commented on DRILL-6236:
---------------------------------------
ilooner commented on a change in pull request #1227: DRILL-6236: batch sizing
for hash join
URL: https://github.com/apache/drill/pull/1227#discussion_r191065198
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinMemoryCalculatorImpl.java
##########
@@ -234,6 +235,7 @@ public HashJoinState getState() {
private int recordsPerPartitionBatchBuild;
private int recordsPerPartitionBatchProbe;
private int outputBatchNumRecords;
+ private int outputBatchSize;
private Map<String, Long> buildValueSizes;
private Map<String, Long> probeValueSizes;
private Map<String, Long> keySizes;
Review comment:
@ppadma I think outputBatchNumRecords, buildValueSizes, probeValueSizes, and
keySizes are unused now since we are directly passing in the outputBatchSize.
This is great since the calculator has been simplified. Could you also delete
these unused parameters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for hash join
> --------------------------
>
> Key: DRILL-6236
> URL: https://issues.apache.org/jira/browse/DRILL-6236
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> limit output batch size for hash join based on memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
