[
https://issues.apache.org/jira/browse/DRILL-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495972#comment-16495972
]
ASF GitHub Bot commented on DRILL-6236:
---------------------------------------
Ben-Zvi commented on a change in pull request #1227: DRILL-6236: batch sizing
for hash join
URL: https://github.com/apache/drill/pull/1227#discussion_r191955603
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
##########
@@ -262,6 +272,7 @@ private void executeProbePhase() throws
SchemaChangeException {
probeBatch.getSchema());
}
case OK:
+
setTargetOutputCount(outgoingJoinBatch.getBatchMemoryManager().update(probeBatch,
LEFT_INDEX,outputRecords));
Review comment:
This code is called when a new LEFT incoming batch is read. At this point
the outgoing batch may be "half full". Looks like this call is modifying the
"targetOutputRecords" variable. If so, then it would not match the allocated
size for the outgoing batch. For example, if made bigger, then the code above
would try to add rows (to the outgoing) beyond the original allocation size !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for hash join
> --------------------------
>
> Key: DRILL-6236
> URL: https://issues.apache.org/jira/browse/DRILL-6236
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> limit output batch size for hash join based on memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
