[
https://issues.apache.org/jira/browse/DRILL-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495994#comment-16495994
]
ASF GitHub Bot commented on DRILL-6236:
---------------------------------------
ppadma commented on a change in pull request #1227: DRILL-6236: batch sizing
for hash join
URL: https://github.com/apache/drill/pull/1227#discussion_r191974514
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
##########
@@ -262,6 +272,7 @@ private void executeProbePhase() throws
SchemaChangeException {
probeBatch.getSchema());
}
case OK:
+
setTargetOutputCount(outgoingJoinBatch.getBatchMemoryManager().update(probeBatch,
LEFT_INDEX,outputRecords));
Review comment:
It will not make it bigger. It will look at remaining memory and adjust the
row count based on that.
final long remainingMemory = Math.max(configOutputBatchSize -
memoryUsed, 0);
// These are number of rows we can fit in remaining memory based on new
outgoing row width.
final int numOutputRowsRemaining =
RecordBatchSizer.safeDivide(remainingMemory, newOutgoingRowWidth);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> batch sizing for hash join
> --------------------------
>
> Key: DRILL-6236
> URL: https://issues.apache.org/jira/browse/DRILL-6236
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> limit output batch size for hash join based on memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
