[
https://issues.apache.org/jira/browse/DRILL-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495864#comment-16495864
]
ASF GitHub Bot commented on DRILL-6236:
---------------------------------------
Ben-Zvi commented on a change in pull request #1227: DRILL-6236: batch sizing
for hash join
URL: https://github.com/apache/drill/pull/1227#discussion_r191950133
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinMemoryCalculatorImpl.java
##########
@@ -448,8 +442,7 @@ private void calculateMemoryUsage()
safetyFactor,
reserveHash);
- maxOutputBatchSize = computeMaxOutputBatchSize(buildValueSizes,
probeValueSizes, keySizes,
- outputBatchNumRecords, safetyFactor, fragmentationFactor);
+ maxOutputBatchSize = (long) (outputBatchSize * fragmentationFactor *
safetyFactor);
Review comment:
Maybe the "outputBatchSize" needs to be casted to (double) to ensure that
the whole multiplication is performed as a double-multiplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for hash join
> --------------------------
>
> Key: DRILL-6236
> URL: https://issues.apache.org/jira/browse/DRILL-6236
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> limit output batch size for hash join based on memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
