[
https://issues.apache.org/jira/browse/DRILL-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592437#comment-16592437
]
ASF GitHub Bot commented on DRILL-6709:
---------------------------------------
bitblender commented on a change in pull request #1444: DRILL-6709: Extended
the batch stats utility to other operators
URL: https://github.com/apache/drill/pull/1444#discussion_r212787951
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
##########
@@ -204,7 +204,12 @@ public HashAggBatch(HashAggregate popConfig, RecordBatch
incoming, FragmentConte
}
hashAggMemoryManager = new HashAggMemoryManager(configuredBatchSize);
- logger.debug("BATCH_STATS, configured output batch size: {}",
configuredBatchSize);
+
+ if (isRecordBatchStatsLoggingEnabled()) {
Review comment:
This outer check is unnecessary because logRecordBatchStats does the same
check. I guess you have it here just to avoid the cost of String.format().
Maybe we should add a var args version which does the string.format internally?
When reading code, I personally like it when I can read as much of the real
function logic in one page, large bodies of logging code make this harder. I
realize it is just 2 extra lines per logging location but it makes it more
verbose.
That said, if you are using an outer check, it allows you to use the "+"
string builder and not use String.format(). String.format() is prone to
mismatch errors between the order in the format string and the order in the
variable list.
This is more of a style comment. I will be ok if you don't change it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch statistics logging utility needs to be extended to mid-stream operators
> -----------------------------------------------------------------------------
>
> Key: DRILL-6709
> URL: https://issues.apache.org/jira/browse/DRILL-6709
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Robert Hou
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> A new batch logging utility has been created to log batch sizing messages to
> drillbit.log. It is being used by the Parquet reader. It needs to be enhanced
> so it can be used by mid-stream operators. In particular, mid-stream
> operators have both incoming batches and outgoing batches, while Parquet only
> has outgoing batches. So the utility needs to support incoming batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
