[
https://issues.apache.org/jira/browse/DRILL-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592440#comment-16592440
]
ASF GitHub Bot commented on DRILL-6709:
---------------------------------------
bitblender commented on a change in pull request #1444: DRILL-6709: Extended
the batch stats utility to other operators
URL: https://github.com/apache/drill/pull/1444#discussion_r212788123
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.java
##########
@@ -279,4 +324,19 @@ private static void
logBatchStatsMsg(RecordBatchStatsContext batchStatsContext,
}
}
+ private static String toString(BatchIOType ioType) {
+ Preconditions.checkNotNull(ioType, "The record batch IO type cannot be
null");
+
+ switch (ioType) {
Review comment:
'case' is generally indented one level into the 'switch'.
Also, Java allows Enums to have constructors and methods that can be used
to associate a string with an enum value. This makes modification of enum names
and attributes easier. See
https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch statistics logging utility needs to be extended to mid-stream operators
> -----------------------------------------------------------------------------
>
> Key: DRILL-6709
> URL: https://issues.apache.org/jira/browse/DRILL-6709
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Robert Hou
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> A new batch logging utility has been created to log batch sizing messages to
> drillbit.log. It is being used by the Parquet reader. It needs to be enhanced
> so it can be used by mid-stream operators. In particular, mid-stream
> operators have both incoming batches and outgoing batches, while Parquet only
> has outgoing batches. So the utility needs to support incoming batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
